Skip to content

add some initial lightweight testing #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 10, 2020
Merged

Conversation

lindsaylevine
Copy link

this also addresses #8 and #12

  1. we see that exact error in issue Plugin load if next is not available #8 running tests if next isnt installed in the project. should i try to mock it? :/
  2. seems we don't need hasFramework anymore with the next require try/catch. also when this is upgraded to a core plugin, won't the framework check be done outside of the plugin?
  3. tried to mock fs in the standard way i mock the other dependencies and ran into a handful of issues. i now use the mock-fs package but calling mockFs broke the internals of hasFramework despite efforts to pass a correct config to mockFs that would appease hasFramework ☹️

@lindsaylevine lindsaylevine requested a review from ehmicky November 6, 2020 13:06
@lindsaylevine lindsaylevine added the type: chore work needed to keep the product and development running smoothly label Nov 6, 2020
@lindsaylevine
Copy link
Author

now fixes #12

@lindsaylevine lindsaylevine merged commit 2849dc5 into main Nov 10, 2020
@lindsaylevine lindsaylevine deleted the ll/initial-tests branch November 10, 2020 11:46
ascorbic added a commit that referenced this pull request Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants